[Sugar-devel] review of the new toolbars implementation

[Tomeu Vizoso]

On Fri, Jul 31, 2009 at 06:27, Aleksey Lim<alsroot at member.fsf.org> wrote:
> On Thu, Jul 30, 2009 at 07:51:07PM +0200, Tomeu Vizoso wrote:
>> Hi,
>> +class _Palette(gtk.Window):
>>
>> The palette class is very tricky and is a frequent source of bugs, we
>> shouldn't duplicate it. Either we add what you need to the existing
>> Palette, or we split it out in a BasePalette and Palette and then
>> inherit from BasePalette for this.
>
> We have two use cases, I guess its worth waiting for 3rd use case
> (or huge refacor) and then refactor Palette code
> (I'm personally dislike idea of refactoring after 2nd use case)

Do you have anything in mind that would be the 3rd case? I also
dislike refactoring now and having to refactor again later, but I
don't see how we can go around this.

Regards,

Tomeu

> --
> Aleksey
>