[Sugar-devel] review of the new toolbars implementation

Aleksey Lim alsroot at member.fsf.org
Fri Jul 31 00:27:37 EDT 2009


On Thu, Jul 30, 2009 at 07:51:07PM +0200, Tomeu Vizoso wrote:
> Hi,
> +class _Palette(gtk.Window):
> 
> The palette class is very tricky and is a frequent source of bugs, we
> shouldn't duplicate it. Either we add what you need to the existing
> Palette, or we split it out in a BasePalette and Palette and then
> inherit from BasePalette for this.

We have two use cases, I guess its worth waiting for 3rd use case
(or huge refacor) and then refactor Palette code
(I'm personally dislike idea of refactoring after 2nd use case)

-- 
Aleksey


More information about the Sugar-devel mailing list