[Sugar-devel] [PATCH] Reduce default emulator resolution to 1024x768

[Bernie Innocenti]

Sascha Silbe wrote:
> On Thu, Feb 19, 2009 at 12:22:50PM +0100, Bernie Innocenti wrote:
> 
>>       if dimensions is not None:
>>           cmd.append('-screen')
>>           cmd.append(dimensions)
>> -    elif gtk.gdk.screen_width() < 1200 or gtk.gdk.screen_height() < 900:
>> +    elif gtk.gdk.screen_width() < DEFAULT_WIDTH or \
>> +            gtk.gdk.screen_height() < DEFAULT_HEIGHT:
>>           cmd.append('-fullscreen')
>>       else:
>>           cmd.append('-screen')
>> -        cmd.append('%dx%d' % (1200, 900))
>> +        cmd.append('%dx%d' % (DEFAULT_WIDTH, DEFAULT_HEIGHT))
> Is it on purpose that non-default dimensions can be set (see first three
> lines) but for determining whether fullscreen will be used the default
> dimensions get examined instead?
> Yes, that part isn't changed by the patch and I've wondered about it
> before, but not bothered to ask. :)

Looks like a bug, indeed.

After discussing a little with Tomeu on IRC, it seems that we have two
kind of users for sugar-emulator:

 - developers who run it from jhbuild

 - very few end users who run it from the desktop menu item

Those we want to bother with this change is of course the developers.
It turns out that some users might actually have been relying on the
implicit switch to full-screen that happens if their desktop is
narrower than 1200 or shorter than 900 pixels.

Since using Sugar in a window does not actually make sense for users,
we might as well change the default of sugar-emulator to go
full-screen by default, and make sugar-jhbuild invoke it with the
1024x768 window for developers.

If it seems likea better strategy, I'll come up with a patch to do this.

-- 
   // Bernie Innocenti - http://www.codewiz.org/
 \X/  Sugar Labs       - http://www.sugarlabs.org/