[Sugar-devel] code review guidelines updated

[Jim Simmons]

Tomeu,

When Aleksey made changes to Read Etexts to support the gstreamer
espeak plugin he had written he made a clone of the Activity in
gitorious, and later this clone was merged back into the mainline.  I
thought this worked pretty well from my standpoint because I could
look at his code before doing the merge and understand what he was
doing first.  I have also appied patches and don't like that nearly as
well.

I have already recommended to someone that wanted to modify one of my
Activities that he follow Aleksey's example and clone the Activity.

James Simmons


> Date: Tue, 11 Aug 2009 19:27:24 +0200
> From: Tomeu Vizoso <tomeu at sugarlabs.org>
> Subject: [Sugar-devel] code review guidelines updated
> To: sugar-devel <sugar-devel at lists.sugarlabs.org>
> Message-ID:
>        <242851610908111027w69f86b10y4a8d2b9d0d18b1da at mail.gmail.com>
> Content-Type: text/plain; charset=ISO-8859-1
>
> Hi,
>
> have tried to clarify and explain the rationale behind the code review
> process in the wiki:
>
> http://wiki.sugarlabs.org/go/Development_Team/Code_Review
> http://wiki.sugarlabs.org/go/Development_Team/Code_guidelines
>
> Would welcome any comments.
>
> Thanks,
>
> Tomeu