[sugar] [PATCH] REVISED screenshots hurt

[C. Scott Ananian]

On Thu, Sep 11, 2008 at 12:39 PM, Erik Garrison <erik at laptop.org> wrote:
> I have revised and tested the patches.  The effects are as follows:
>
> On Fri, Sep 05, 2008 at 01:31:54AM -0300, Erik Garrison wrote:
>>   before, screenshots taken on these events:
>>     - frame visibility
>>     - tabbing start
>>     - activity next tab
>>     - activity previous tab
>>     - zoom into activity view
>>     - activity close (twice)
>>
>>   after, screenshots taken on these events:
>>     - activity close (once)
>>     - activity keep / save
>
> I dropped the screenshot acquisition code into Activity.copy() and
> Activity.close() so that both user-initated 'keep' (==copy) and 'close'
> events (both keyboard initiated and frame-click initiated) will take
> screenshots for use in the journal.
>
> The patches are attached to this email.  Should I make a new track
> ticket for this issue to log the introduction?
>
> Any objections or thoughts?

Please file a trac ticket, attach the patches there, and request
review using the standard sugar process.  Mention the trac ticket here
on sugar@, and those interested in further discussion can cc
themselves on the trac ticket.

Nothing goes into 8.2 at this point without a trac ticket, so you
might as well create one sooner rather than later.
 --scott

-- 
 ( http://cscott.net/ )