[sugar] [PATCH] screenshots hurt

[Erik Garrison]

On Fri, Sep 05, 2008 at 06:20:17PM +0200, Marco Pesenti Gritti wrote:
> On Fri, Sep 5, 2008 at 4:47 PM, Erik Garrison <erik at laptop.org> wrote:
> > By "problem" I was referring to the issue that the screenshots are used
> > to resolve.  I now am clear that the problem is that users can't figure
> > out what's what in their journal without screenshots.  The current
> > patchset attempts to resolve this issue in a way that doesn't affect
> > the performance of window change events in Sugar.
> 
> I can think of a couple of limitation with your approach (aside from
> the implementation issue we discussed in irc, which can be easily
> fixed):
> 
> 1 If you close the an activity while the frame is up, you will get a
> screenshot with some black areas.
> 2 If you close a non-active activity from the frame (icon palette) you
> would get a completely black screenshot.
> 

I'm somewhat bothered by the completely black screenshot but see no
immediate way to alleviate it.

Another issue with the current patchset is that if the activity is
closed by a signal from the window manager (e.g. when the user selects
the 'shutdown' option from the system palette in the home view) then the
screenshots are not taken, as activity.Activity.close() is not hit.
Thanks to Andr?s for pointing this out.

Is this signal implemented?  Should we move the screenshot event into
activity.Activity.prepare_close() instead.  It appears this is hit every
time we close by any method.

Erik