[sugar] [PATCH] REVISED screenshots hurt (Erik Garrison)

[Greg Smith]

Hi Guys,

That's a winner!

Thanks to Martin D for explaining that screen shots are only used in the 
Journal details view. That makes sense now.

I leave it to Michael et al to decide if this patch is safe enough to 
try in the release candidate. If it improves performance as much as it 
appears, I think its worth serious consideration.

Thanks,

Greg S


> Date: Fri, 5 Sep 2008 01:31:54 -0300
> From: Erik Garrison <erik at laptop.org>
> Subject: Re: [sugar] [PATCH] REVISED screenshots hurt
> To: sugar at lists.laptop.org
> Message-ID: <20080905043154.GR10213 at eggs>
> Content-Type: text/plain; charset="us-ascii"
> 
> Devs,
> 
> Attached to this email are both the original patch, which removes
> automated screenshot acquisition from the sugar shell, and a patch to
> activity.py in sugar-toolkit which adds screenshot acquisition to the
> user-directed 'keep' (save) event, so that the screenshot can appear in
> the journal when the user explicitly selects to save their work.
> 
> Note that the keep event previously did not acquire a screenshot-- it
> was apparently assumed that it would have been acquired previously by a
> tabbing event.  Additionally, two screenshots were acquired on every
> close event (one in the Shell.py code and one in the activity.py code).
> 
> The effect of these patches is to retain the benefits of screenshots
> without incurring their costs on every window navigation event.  Only
> user-directed 'close' and 'keep' events now trigger the screenshot.
> This means that there will always be screenshots after activities
> properly exit, or when the user elects to save data.  Other automated
> screenshot events are removed so that system responsiveness does not
> suffer during window manager navigation.
> 
>   before, screenshots taken on these events:
>     - frame visibility
>     - tabbing start
>     - activity next tab
>     - activity previous tab
>     - zoom into activity view
>     - activity close (twice)
> 
>   after, screenshots taken on these events:
>     - activity close (once)
>     - activity keep / save
> 
> Comments welcome.  Please test and report results.
> 
> Erik
> ------