[sugar] [PATCH] REVISED screenshots hurt

[Erik Garrison]

Devs,

Attached to this email are both the original patch, which removes
automated screenshot acquisition from the sugar shell, and a patch to
activity.py in sugar-toolkit which adds screenshot acquisition to the
user-directed 'keep' (save) event, so that the screenshot can appear in
the journal when the user explicitly selects to save their work.

Note that the keep event previously did not acquire a screenshot-- it
was apparently assumed that it would have been acquired previously by a
tabbing event.  Additionally, two screenshots were acquired on every
close event (one in the Shell.py code and one in the activity.py code).

The effect of these patches is to retain the benefits of screenshots
without incurring their costs on every window navigation event.  Only
user-directed 'close' and 'keep' events now trigger the screenshot.
This means that there will always be screenshots after activities
properly exit, or when the user elects to save data.  Other automated
screenshot events are removed so that system responsiveness does not
suffer during window manager navigation.

  before, screenshots taken on these events:
    - frame visibility
    - tabbing start
    - activity next tab
    - activity previous tab
    - zoom into activity view
    - activity close (twice)

  after, screenshots taken on these events:
    - activity close (once)
    - activity keep / save

Comments welcome.  Please test and report results.

Erik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sugar-no_screen_shots.patch
Type: text/x-diff
Size: 2205 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080905/fc260151/attachment.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sugar-toolkit-no_screen_shots.patch
Type: text/x-diff
Size: 434 bytes
Desc: not available
Url : http://lists.laptop.org/pipermail/sugar/attachments/20080905/fc260151/attachment-0001.patch