[sugar] [PATCH] Refactor bundlebuilder

Morgan Collett morgan.collett
Mon May 26 04:09:12 EDT 2008

On Mon, May 26, 2008 at 1:57 AM, Marco Pesenti Gritti
<mpgritti at gmail.com> wrote:
> Hello,
> the attached patch refactors bundlebuilder. I'd appreciate a review
> before doing extensive testing.
> You can see the incremental changeset here:
> http://dev.laptop.org/git?p=users/marco/sugar-toolkit;a=summary
> Other than cleanups the significant changes are:
> * The file inclusion logic is no more based on git/svn or a manifest
> file, instead we include all the files except well known like
> .git/.gitignore and source files like those in the po directory. This
> is unusual compared to common build systems, but it should work well
> for python bundles. The idea is that the source directory is almost
> the same of the distributed bundle.
> * dist_xo generate a xo, dist_source generate a source tarball.
> I'm planning to add better support for generated files using make
> (most common case being compiled C code). But I'd rather do that as a
> separate step. Also if desired we can easily allow to override the
> default file inclusion logic, or provide a choice of them (the one
> this patch implements is experimental).
> Marco

Since bundle signing will need a manifest, and AFAIK Develop needs an
accurate manifest, what about autogenerating the manifest from the
files included? I have been bitten before by not updating MANIFEST
when adding files and it may become a common problem.


More information about the Sugar-devel mailing list