[sugar] web-activity fix
Mon May 12 04:46:33 EDT 2008
On Sun, May 11, 2008 at 7:56 PM, Dan Krejsa <dan.krejsa at alamedanet.net> wrote:
> The attached change in web-activity/downloadmanager.py fix a
> problem causing Browse downloads to fail with an exception in
> onProgressChange64() due to _create_journal_object() having failed
> to be called earlier from onStateChange() when state_flags contained
> the bit STATE_START, but also other bits as corresponding to
> State Type Flags from nsIWebProgressListener.idl.
> I'm pretty confident about the changes in onStateChange(), but
> the change (eliminating a trailing '"' character) in the
> components.registrar.registerFactory() calls are fairly gratuitous,
> and should be checked by someone who is familiar with that API.
r+ to me.
More information about the Sugar-devel