[sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

Jameson "Chema" Quinn jquinn
Sun Jun 8 16:12:36 EDT 2008

On Sun, Jun 8, 2008 at 1:42 PM, Marco Pesenti Gritti <mpgritti at gmail.com>

> On Sun, Jun 8, 2008 at 9:26 PM, Jameson Chema Quinn
> <jquinn at cs.oberlin.edu> wrote:
> > Here is the revised patch. It has your suggested changes, plus a couple
> > more:
> >
> > - Check for existence of po directory in Builder
> > - Config.__init__() is cleaned up. Now gets bundle name from
> activity.info.
> > start() no longer needs a bundle name, and has deprecation warning. Also
> I
> > put things in a more logical order.
> Jameson,
> *please* do *not* make any additional changes when submitting a new
> patch. Limit yourself to the changes requested by the reviewer.
> Additional fixes/improvements should go in a separate patch.


In my defense, you did ask me to remove the extra parameters from the
__init__ functions. The best way to do that was to clean up Config.

The po check, you are right, should be separate, even though it is only a
simple 3-line patch.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.laptop.org/pipermail/sugar/attachments/20080608/ed8d7d47/attachment.htm 

More information about the Sugar-devel mailing list