[sugar] [PATCH] Bundlebuilder use manifest, fix_manifest function

Marco Pesenti Gritti mpgritti
Sun Jun 8 05:11:54 EDT 2008


On Sun, Jun 8, 2008 at 3:51 AM, Jameson Chema Quinn
<jquinn at cs.oberlin.edu> wrote:
> Sorry, Marco, but here is yet another version of the patch. I decided to
> refactor the Config class out of bundlebuilder - all it was carrying in the
> common start() case was bundle_name; and as for other cases, it is simpler
> to call Builder(...params...) than Builder(Config(...params...)).

I'm not convinced that's a good idea. But anyway, let's not increase
the scope of the patch, as I told you I already had problems to review
it in his current form. I'll review the old versions of the patch and
when that's done we can consider this change.

Thanks,
Marco



More information about the Sugar-devel mailing list