[sugar] [PATCH] Fix appearance of activity bundles (in Journal)
Eben Eliason
eben.eliason
Wed Apr 23 15:23:26 EDT 2008
Ah, thanks for clarifying. This was the approach used in
expandedentry, and it seemed reasonable to simplify to this in
collapsedentry as well.
Should I simply add:
if title_text == '':
title_text = _('Untitled')
Or should I rewrite the whloe check a la:
title_text = _('Untitled')
if jobject.metadata.has_key['title'] and jobject.metadata.has_key['title']:
title_text = jobject.metadata['title']
Thoughts?
- Eben
On Wed, Apr 23, 2008 at 3:12 PM, Tomeu Vizoso <tomeu at tomeuvizoso.net> wrote:
> Hi,
>
> + title_text = jobject.metadata.get('title', _('Untitled'))
>
> _('Untitled') will be used only if the title property doesn't exist,
> so there may appear '' instead of 'Untitled'.
>
> Thanks,
>
> Tomeu
>
>
>
> On Wed, Apr 23, 2008 at 9:01 PM, Eben Eliason <eben.eliason at gmail.com> wrote:
> > This fixes the appearance of both icons and titles of activity bundles
> > in the Journal. The icons are now rendered as gray outlines, matching
> > those in the activity list of Home. The titles are now used directly,
> > eliminating the "bug" which caused " Activity" to be appended every
> > time a the title of one was edited.
> >
> > - Eben
> >
> > _______________________________________________
> > Sugar mailing list
> > Sugar at lists.laptop.org
> > http://lists.laptop.org/listinfo/sugar
> >
> >
>
More information about the Sugar-devel
mailing list