[sugar] [PATCH] (partial) AP palette patch

[Simon Schampijer]

Thanks Tomeu for reviewing.

I few things I found out when looking into that - I don't think 
introduced by the patch but maybe worth to look at.

- I had the 'connecting...' label in the palette on the mesh view even 
though I was already connected. Later it went away.
- The palette of the AP in the frame should probably get rid of the 
'Disconnecting...' label as well and make it 'Disconnecting' - well 
introduce the new layout here as well
- Sometimes the AP icon in the frame is black and white - even though I 
am connected fine

Simon

Tomeu Vizoso wrote:
> r+
> 
> On Thu, Apr 10, 2008 at 3:02 PM, Simon Schampijer <simon at schampijer.de> wrote:
>> Eben Eliason wrote:
>>
>>>>  I made the following changes to the patch:
>>>>  - display the AP icon in the palette in color
>>>>  - display the badge as well
>>>>  - removed the channel info in the secondary-text (for now)
>>>>
>>> Sounds good.
>>>
>>>
>>>>  What do you mean here?
>>>>  +            self.props.icon_name = icon_name
>>>>  +            # This breaks style guidelines; we should store a
>> reference
>>>>  +            self._palette._icon.props.icon_name = icon_name
>>>>
>>> I'm accessing the private _icon member of the palette class, rather
>>> than keeping a reference to it to use for this purpose.  It was a
>>> quick hack.
>>>
>>  I changed this now to be:
>>
>>
>>  +            self.props.icon_name = icon_name
>>  +            icon = self._palette.props.icon
>>  +            icon.props.icon_name = icon_name
>>
>>  Full patch is attached.
>>
>>
>>
>>>>  The Connect icon is 'dialog-ok' the disconnect 'media-eject', should we
>>>> make this 'dialog-cancel' to be consistent?
>>>>
>>> Well, it's consistent in naming, but not necessarily in experience.
>>> Where possible, I'd like to find ways to avoid the overloaded 'x'
>>> icon.  It seems that using the eject icon for various types of
>>> external media makes sense, and I thought it might also apply to
>>> access points, which we treat as wireless devices.  Alternately, I'd
>>> be open to a better suggestion for a "connect" icon.
>>>
>>  Yeah that sounds maybe like the best approach - to have a specific icon for
>> connect/disconnect. Using a plug (connected/unconnected) icon might suggest
>> a physical connection - not sure if we would want that association. Let's
>> see if I can come up with something better.
>>
>>
>>
>>>>  Another thought that come to my mind - the AP icon in the frame should
>>>> maybe come with a badge as well.
>>>>
>>> Hmm, perhaps.  Although I'm not sure that the info provided by the
>>> badge is needed once it is shown in the Frame anyway. Also, we need to
>>> leave room for an alert badge if the wireless device in the Frame has
>>> trouble. I'd leave it as is, for now.
>>>
>>  I thought of it more like instantly knowing which AP you are connecting to.
>> The badge is a visual hint as well. But the alert badge might be a reason
>> not to have it.
>>
>>  Simon
>>
>> _______________________________________________
>>  Sugar mailing list
>>  Sugar at lists.laptop.org
>>  http://lists.laptop.org/listinfo/sugar
>>
>>