[sugar] Initial Security Patches

Marco Pesenti Gritti mpgritti
Wed Aug 1 07:48:50 EDT 2007


On 8/1/07, Michael Stone <michael at laptop.org> wrote:
> Simon,
>
> On Tue, 2007-07-31 at 14:20 +0100, Simon McVittie wrote:
> > On Mon, 30 Jul 2007 at 16:21:36 -0400, Michael Stone wrote:
> > >      @dbus.service.signal(_DBUS_OWNER_IFACE, signature="s")
> > >      def CurrentActivityChanged(self, activity_id):
> > > -        pass
> > > +        if os.path.exists('/etc/olpc-security'):
> > > +            self.rainbow.activity_changed(activity_id)
> >
> > Minor: It's conventional for D-Bus methods to be named in CamelCase.
>
> I don't care much whether we follow this convention or the PEP-8
> convention:
>
>     "Function names should be lowercase, with words separated by
>     underscores as necessary to improve readability."

I think we should follow the D-Bus convention here. All the new code
in Sugar follows it (and we should probably fix the cases which
doesn't).

Marco



More information about the Sugar-devel mailing list