[SoaS] SoaS

[Wade Brainerd]

The Terminal segfault when saving to the Journal in F12 and newer is
fixed in Terminal v31.

A workaround was added to terminal.py, and a proper bug report & patch
for vte were posted to Bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=556200

I also unified the toolbar code while I was in there, so the latest
Terminal should work on all shipped versions of Sugar with new or old
toolbars.

-Wade

On Mon, Dec 21, 2009 at 11:24 PM, Wade Brainerd <wadetb at gmail.com> wrote:
> Actually I take it back, this is not a real solution.  I'll keep investigating.
>
> On Mon, Dec 21, 2009 at 10:20 PM, Wade Brainerd <wadetb at gmail.com> wrote:
>> This patch to terminal.py solves Terminal crashing when switching
>> away.  Need to check whether passing None for callback is valid on
>> older releases like OLPC 820.  If so, I think we should apply the
>> patch to Terminal given that it's faster.
>>
>> --- terminal.py 2009-12-21 22:12:06.027828821 -0500
>> +++ terminal.py.vtefix  2009-12-21 22:11:15.084855179 -0500
>> @@ -369,9 +369,7 @@
>>         for i in range(self._notebook.get_n_pages()):
>>             page = self._notebook.get_nth_page(i)
>>
>> -            def selected_cb(terminal, c, row, cb_data):
>> -                return 1
>> -            (scrollback_text, attributes_) = page.vt.get_text(selected_cb, 1)
>> +            (scrollback_text, attributes_) = page.vt.get_text(None)
>>
>>             scrollback_lines = scrollback_text.split('\n')
>>
>> -Wade
>>
>> On Mon, Dec 21, 2009 at 8:20 PM, Wade Brainerd <wadetb at gmail.com> wrote:
>>> I tracked it down to the vte.get_text() call, but have been unable to
>>> determine the cause.  Possibly related to a newer vte version?
>>>
>>> -Wade
>>>
>>> On Mon, Dec 21, 2009 at 4:30 PM, Gary C Martin <gary at garycmartin.com> wrote:
>>>> Hi Wade/Tomeu,
>>>>
>>>> On 21 Dec 2009, at 15:44, Tomeu Vizoso wrote:
>>>>
>>>>> On Mon, Dec 21, 2009 at 15:34, Wade Brainerd <wadetb at gmail.com> wrote:
>>>>>> On Mon, Dec 21, 2009 at 5:41 AM, Tomeu Vizoso <tomeu at sugarlabs.org> wrote:
>>>>>>> On Sun, Dec 20, 2009 at 23:54, Wade Brainerd <wadetb at gmail.com> wrote:
>>>>>>>> Hi all,
>>>>>>>>
>>>>>>>> I fixed most of the issues reported by Gary, and posted a new
>>>>>>>> VirtualBox appliance:
>>>>>>>>
>>>>>>>>    http://people.sugarlabs.org/~wadeb/soas-blueberry-vmdk.zip
>>>>>>>>
>>>>>>>> Notes:
>>>>>>>>
>>>>>>>> - I still do not know why Terminal quits when switching to another
>>>>>>>> activity - likely something to do with saving its state to the
>>>>>>>> Journal.
>>>>>>>
>>>>>>> If by quits you mean the process disappears, then it's likely a crash.
>>>>>>> I suspect the screenshot taking, but gdb would tell, from a ssh
>>>>>>> session attach to the terminal process and when it dies do a bt full.
>>>>>>
>>>>>> The last lines in the log are:
>>>>>>
>>>>>> ** (sugar-activity:1010): DEBUG: Got client ID
>>>>>> "10810f1cfb278f8dcb126140952484782000000008540000"
>>>>>> ** (sugar-activity:1010): DEBUG: Setting initial properties
>>>>>> ** (sugar-activity:1010): DEBUG: Received SaveYourself(SmSaveLocal,
>>>>>> !Shutdown, SmInteractStyleNone, !Fast) in state idle
>>>>>> ** (sugar-activity:1010): DEBUG: Sending SaveYourselfDone(True) for
>>>>>> initial SaveYourself
>>>>>> ** (sugar-activity:1010): DEBUG: Received SaveComplete message in
>>>>>> state save-yourself-done
>>>>>> Activity died: pid 1010 condition 139 data (None, <open file
>>>>>> '<fdopen>', mode 'w' at 0x922bcf0>)
>>>>
>>>> I've been getting a little more in the log files than Wade for both of the vmdk images so far, not sure if it helps:
>>>>
>>>> ** (sugar-activity:1059): DEBUG: Got client ID "107ca3fcc1267235f4126142889997175000000008970003"
>>>> ** (sugar-activity:1059): DEBUG: Setting initial properties
>>>> ** (sugar-activity:1059): DEBUG: Received SaveYourself(SmSaveLocal, !Shutdown, SmInteractStyleNone, !Fast) in state idle
>>>> ** (sugar-activity:1059): DEBUG: Sending SaveYourselfDone(True) for initial SaveYourself
>>>> ** (sugar-activity:1059): DEBUG: Received SaveComplete message in state save-yourself-done
>>>> /usr/lib/python2.6/site-packages/sugar/datastore/datastore.py:58: UnicodeWarning: Unicode unequal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
>>>>  if not self._props.has_key(key) or self._props[key] != value:
>>>> Activity died: pid 1059 condition 139 data (None, <open file '<fdopen>', mode 'w' at 0x9488a70>)
>>>>
>>>>> I cannot conclude anything from that :/ If someone has some minutes to
>>>>> try the gdb method, I can walk them through in #sugar.
>>>>
>>>> I can give that a go, new to me, so may ping your on IRC for some hints :-)
>>>>
>>>> Regards,
>>>> --Gary
>>>>
>>>>
>>>
>>
>