Thanks Ajay, this patch works well. I just have one comment, when the messages are not displayed the icon-frame shows a blank space.<br><br>This patch will be included in dx3?<br><br>cheers,<br>Esteban. <br><br><div class="gmail_quote">

2011/12/21 Ajay Garg <span dir="ltr"><<a href="mailto:ajay@activitycentral.com">ajay@activitycentral.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

Issue:<br>
------<br>
Originally discussed at :<br>
<a href="http://lists.sugarlabs.org/archive/dextrose/2011-August/001340.html" target="_blank">http://lists.sugarlabs.org/archive/dextrose/2011-August/001340.html</a><br>
<br>
and catched by Esteban Bordón, the issue is that whenever (and not just<br>
at startup) any notification-messages are displayed, any Activity-icon<br>
(and not just the Journal-Activity icon) is not displayed in the<br>
top-panel-frame.<br>
<br>
Technical history/details, plus the fix :<br>
-----------------------------------------<br>
<br>
The mesh-, group-, home-, and activity-zoom buttons are a group of<br>
radiobuttons; only one may be visibly-active at a time (this is<br>
highlighted by the white-background of the corresponding selected<br>
zoom-button).<br>
Please see:<br>
                "src/jarabe/frame/zoomtoolbar.py"<br>
for code-details.<br>
<br>
Similarly, all the opened activity-instances are shown by a yet another<br>
group of radiobuttons; the selected activity being highlighed by the<br>
corresponding selected activity-icon-button.<br>
<br>
Now, what was happening, was that the notification-message-icon was<br>
being added into the Activities-Tray (the second group of radiobuttons<br>
as discussed above); but any further activity-icons were not being added<br>
into the tray, because the notification-message-icon did not respect the<br>
semantics of the activity-icons. Hence, the notification-message-icon, and<br>
any other activity-icon (including Journal-activity icon) were not being<br>
made a part of the same group.<br>
<br>
Thus, the fix is that now the notification-message-icon, goes into a<br>
third tray, in the top-panel-frame. This third tray, is actually a<br>
simple gtk.HBox, with size equal to 1 grid.<br>
Please see:<br>
                "src/jarabe/frame/frame.py"<br>
                "src/jarabe/frame/activitiestray.py"<br>
for code-details.<br>
<br>
Signed-off-by: Ajay Garg <<a href="mailto:ajay@activitycentral.com">ajay@activitycentral.com</a>><br>
---<br>
 src/jarabe/frame/frame.py |   10 ++++++++--<br>
 1 files changed, 8 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/jarabe/frame/frame.py b/src/jarabe/frame/frame.py<br>
index cd1dc20..fbf45fc 100644<br>
--- a/src/jarabe/frame/frame.py<br>
+++ b/src/jarabe/frame/frame.py<br>
@@ -195,6 +195,12 @@ class Frame(object):<br>
                 box_width=4 * style.GRID_CELL_SIZE))<br>
         zoom_toolbar.show()<br>
<br>
+        message_tray = gtk.HBox()<br>
+        panel.append(hippo.CanvasWidget(widget=message_tray,<br>
+                box_width=1 * style.GRID_CELL_SIZE))<br>
+        message_tray.show()<br>
+        self._message_tray = message_tray<br>
+<br>
         activities_tray = ActivitiesTray()<br>
         panel.append(hippo.CanvasWidget(widget=activities_tray),<br>
                 hippo.PACK_EXPAND)<br>
@@ -321,7 +327,7 @@ class Frame(object):<br>
         elif corner == gtk.CORNER_TOP_RIGHT:<br>
             self._friends_tray.add_item(button)<br>
         else:<br>
-            self._activities_tray.add_item(button)<br>
+            self._message_tray.add(button)<br>
<br>
     def _remove_message_button(self, button, corner):<br>
         if corner == gtk.CORNER_BOTTOM_RIGHT:<br>
@@ -329,7 +335,7 @@ class Frame(object):<br>
         elif corner == gtk.CORNER_TOP_RIGHT:<br>
             self._friends_tray.remove_item(button)<br>
         else:<br>
-            self._activities_tray.remove_item(button)<br>
+            self._message_tray.remove(button)<br>
<br>
     def _launch_notification_icon(self, icon_name, xo_color,<br>
                                   position, duration):<br>
<span class="HOEnZb"><font color="#888888">--<br>
1.7.4.4<br>
<br>
</font></span></blockquote></div><br>