James and Aleksey,<div><br></div><div>Appreciate your feedback.</div><div><br></div><div>We
have made quite a number of mistakes in our previous patch. We have
incorporated your recommendations, and are sending a new revised patch
to the list serv.</div>
<div><br></div><div>Kindly let us know whether it meets all the requirements. Thanks again for reviewing the patch submissions.</div><div><br></div><div>Regards,</div><div><br></div>Anubhav<br><br><div class="gmail_quote">
On Sat, Oct 23, 2010 at 3:00 PM, James Cameron <span dir="ltr"><<a href="mailto:quozl@laptop.org">quozl@laptop.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On Sat, Oct 23, 2010 at 01:11:18AM +0530, <a href="mailto:anubhav@seeta.in">anubhav@seeta.in</a> wrote:<br>
</div><div class="im">> Downgrading an activity is now made possible. When a .xo file of a version older<br>
> than the currently installed version is clicked, a downgrading option is made<br>
> available, by popping up of a confirmation alert. Depending upton the choice<br>
> selected you can downgrade the activity.<br>
<br>
</div>upton is a brand of tea here. Perhaps you mean upon.<br>
<div class="im"><br>
><br>
> diff --git a/src/jarabe/journal/misc.py b/src/jarabe/journal/misc.py<br>
</div><div class="im">> +def older_version_clicked(metadata):<br>
> + alert = ConfirmationAlert()<br>
> + alert.props.title = _('Newer Version Found')<br>
> + alert.props.msg = _('Newer version of the chosen activity is available \<br>
> + do you still want to continue with the installation? \<br>
> + If Yes click Ok and the activity icon of the older \<br>
> + .xo file in the Journal')<br>
<br>
</div>Huh? I don't understand what this text means, it seems to be an<br>
incomplete english sentence. Let me remove the program code to expose<br>
the message the user will get:<br>
<br>
"Newer Version Found: Newer version of the chosen activity is available<br>
<div class="im">do you still want to continue with the installation? If Yes click Ok<br>
and the activity icon of the older .xo file in the Journal"<br>
<br>
</div>Problems with this english text are:<br>
<br>
0. "Newer Version Found" doesn't really describe the situation, that of<br>
an update reversal, or downgrade,<br>
<br>
1. the first sentence is incorrectly formed; it actually contains two<br>
sentences without separating punctuation,<br>
<br>
2. the second sentence ends abruptly without completing the phrase,<br>
<br>
3. the second sentence asks the user to click "the activity icon of the<br>
older .xo file in the Journal", which doesn't seem right,<br>
<br>
4. "the chosen activity" might be replaced by the name of the activity,<br>
<br>
5. the version number already installed and the version number<br>
requested are not mentioned,<br>
<br>
6. while one might guess that clicking Cancel will stop and unwind the<br>
operation, it isn't clear what clicking Ok will do.<br>
<br>
It is very important to get this message correct and succinct, since it<br>
needs to be translated into other languages.<br>
<font color="#888888"><br>
--<br>
James Cameron<br>
<a href="http://quozl.linux.org.au/" target="_blank">http://quozl.linux.org.au/</a><br>
</font><div><div></div><div class="h5">_______________________________________________<br>
Sugar-devel mailing list<br>
<a href="mailto:Sugar-devel@lists.sugarlabs.org">Sugar-devel@lists.sugarlabs.org</a><br>
<a href="http://lists.sugarlabs.org/listinfo/sugar-devel" target="_blank">http://lists.sugarlabs.org/listinfo/sugar-devel</a><br>
</div></div></blockquote></div><br>