Your patch fixes sugar-datastore and this fixes sugar-toolkit. I don't know why exists 2 different datastore.py but sugar-toolkit's datastore.py is used by activities to interface with the Journal. Your patch is actually included in Dextrose. cheers, Esteban. <div class="gmail_quote">2010/10/13 Andrés Ambrois <<a href="mailto:andresambrois@gmail.com">andresambrois@gmail.com</a>> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im">On Wednesday, October 13, 2010 09:37:01 am Esteban Bordon wrote: > I attach a patch to fix Journal sort by creation date. It sets ctime=now > when a Journal entry is created. > > Index: sugar-toolkit-0.88.1/src/sugar/datastore/datastore.py > =================================================================== > --- sugar-toolkit-0.88.1.orig/src/sugar/datastore/datastore.py > +++ sugar-toolkit-0.88.1/src/sugar/datastore/datastore.py > @@ -305,6 +305,8 @@ def create(): > metadata = DSMetadata() > metadata['mtime'] = datetime.now().isoformat() > metadata['timestamp'] = int(time.time()) > + if not metadata.get('ctime'): > + metadata['ctime'] = time.strftime("%Y-%m-%dT%H:%M:%S", > time.localtime()) > return DSObject(object_id=None, metadata=metadata, file_path=None) </div>It's strange that this line is not present in Dextrose. What build is this? This change is present patch listed in [0]. In any case, the sorting patches were much improved in mainline (we're using a "creation_time" property now), maybe it would be better to cherry pick those commits instead of forking the development of this feature? I don't know what the backport/bugfix policy for Dextrose is in these cases. This patch is correct of course, but I wonder what other stuff may be missing from my series... [0] <a href="http://wiki.sugarlabs.org/go/Dextrose/TODO/Patches" target="_blank">http://wiki.sugarlabs.org/go/Dextrose/TODO/Patches</a> (sizelist-0004-Add-ctime-property-to-the-index-and-datastore.patch) <div class="im"> > > cheers, > Esteban. > > 2010/10/13 Bernie Innocenti <<a href="mailto:bernie@codewiz.org">bernie@codewiz.org</a>> > > > On Tue, 2010-10-12 at 13:40 -0200, Esteban Bordon wrote: > > > Hi all. > > > > > > I was making a patch for Journal sort by creation date for Dextrose > > > and I found 2 datastore.py in the OS. > > > > > > /usr/lib/python2.6/site-packages/sugar/datastore.py and > > > /usr/lib/python2.6/site-packages/carquinyol/datastore.py > > > > > > One of those belong to sugar-toolkit and the other one belong to > > > sugar-datastore. The second includes a patch for this issue but it > > > doesn't shows correctly in Journal. > > > > > > must I to change sugar-toolkit? > > > > The datastore.py in sugar-toolkit is used by activities to interface > > with the Journal (wrapping its dbus protocol). The datastore.py in > > carquinyol is the actual datastore. > > > > Adding Sascha and Andres on cc, in case they want to add something. > > > > -- > > // Bernie Innocenti - <a href="http://codewiz.org/" target="_blank">http://codewiz.org/</a> > > \X/ Sugar Labs - <a href="http://sugarlabs.org/" target="_blank">http://sugarlabs.org/</a> > > > > > </div>-- -Andrés </blockquote></div>