[Dextrose] [PATCH] Fix for bugs sl#2713 and au#885.
alsroot at activitycentral.org
Mon Sep 12 15:59:56 EDT 2011
On Mon, Sep 12, 2011 at 12:35:17AM +0530, Ajay Garg wrote:
> Running the "dextrose-updater" cron.daily job, "touches" a "/var/lib/dextrose-updater" file. This file is then used in the subsequent run, to determine if it
> is ok to re-run the job. Effectively, the "last-touched-timestamp" value of "/var/lib/dextrose-updater" is made use of in the "dextrose-updater" job script.
> Used similar logic - used the "last-touched-time" as the time when the yum-updater was last run.
> Thanks to Anish, for some wonderful review feedback.
There are a couple of issues in the patch, but my concern is about
not having all hardcoded stuf (not only for dextrose but, eg, for OLPC's
XS) in shell code and relying only on command line API (the reason is
that this command might be called w/o shell's UI at all and might have
quite different release schedule in comapring w/ shell).
In other words, it will be useful to:
* rehash such code in Dextrose patch (for updater and school server backups)
* rehash XS related code
* create a Feature/ page on SL wiki for such refactoring/adding-new-code
* in Feature's code, use sugar-client command line API to all
interactions with [school] server (and hide such UI if sugar-client
command doesn't exist)
More information about the Dextrose