[Dextrose] [PATCH 2/2] Fix all xo models path version

Anish Mangal anish at sugarlabs.org
Tue Feb 15 10:14:47 EST 2011


agree, i fear we have plenty of patches like this

On Mon, Feb 14, 2011 at 21:03, Bernie Innocenti <bernie at codewiz.org> wrote:
> On Mon, 2011-02-14 at 17:48 -0300, Martin Abente wrote:
>> Expiration date feature was using a harcoded
>> lease.sig path, which was only available for
>> the XO 1.0.
>>
>> This add a new method to determine which path
>> should be used.
>
> Why not repost an updated version of the original patch?
>
> It does not make much sense for a reviewer to se one patch that does
> something in an incorrect way, immediately followed by a second patch
> that changes the code to something different.
>
> We should keep our patch queue clean so it's easy to merge upstream.
>
> --
>   // Bernie Innocenti - http://codewiz.org/
>  \X/  Sugar Labs       - http://sugarlabs.org/
>
>
>



-- 
Anish | anish at sugarlabs.org


More information about the Dextrose mailing list