[Dextrose] [PATCH] Fix no restart after provider info selection

Anish Mangal anishmangal2002 at gmail.com
Tue Feb 1 20:37:28 EST 2011


It applies cleanly after applying "Database support for 3G control panel" patch.

Sorry for the confusion.

On Tue, Feb 1, 2011 at 22:27, Anish Mangal <anishmangal2002 at gmail.com> wrote:
> Hi,
>
> This doesn't seem to apply cleanly. Infact this tries to tinker with
> line numbers ~340 and beyond, while I see only 250 lines in view.py.
>
> On Tue, Jan 11, 2011 at 11:54, Martin Abente
> <martin.abente.lahaye at gmail.com> wrote:
>> Current 3g provider information selection logic bypassed the
>> validation process, thefore no restart was required.
>>
>> Note that changes in the current session does not modify
>> the current loaded connection information, and since the
>> connection information is loaded at startup, restart is
>> required.
>>
>> ---
>>  extensions/cpsection/modemconfiguration/view.py |   12 ++++--------
>>  1 files changed, 4 insertions(+), 8 deletions(-)
>>
>> diff --git a/extensions/cpsection/modemconfiguration/view.py b/extensions/cpsection/modemconfiguration/view.py
>> index 3b03b3d..1e465cf 100644
>> --- a/extensions/cpsection/modemconfiguration/view.py
>> +++ b/extensions/cpsection/modemconfiguration/view.py
>> @@ -340,14 +340,10 @@ class ModemConfiguration(SectionView):
>>     def __plan_selected_cb(self, combo):
>>         model = combo.get_model()
>>         plan = model.get_row_plan(combo.get_active())
>> -        self._username_entry.set_value(plan['username'])
>> -        self._username_entry.set_text_from_model()
>> -        self._password_entry.set_value(plan['password'])
>> -        self._password_entry.set_text_from_model()
>> -        self._number_entry.set_value(plan['number'])
>> -        self._number_entry.set_text_from_model()
>> -        self._apn_entry.set_value(plan['apn'])
>> -        self._apn_entry.set_text_from_model()
>> +        self._username_entry.entry.set_text(plan['username'])
>> +        self._password_entry.entry.set_text(plan['password'])
>> +        self._number_entry.entry.set_text(plan['number'])
>> +        self._apn_entry.entry.set_text(plan['apn'])
>>
>>     def _validate(self):
>>         if self._username_entry.is_valid and \
>> --
>> 1.7.1
>>
>> _______________________________________________
>> Dextrose mailing list
>> Dextrose at lists.sugarlabs.org
>> http://lists.sugarlabs.org/listinfo/dextrose
>>
>
>
>
> --
> Anish
>



-- 
Anish


More information about the Dextrose mailing list