[Dextrose] [Sugar-devel] [PATCH v5 sugar] Pulsing icon delayed by 5 seconds or so SL#2080

[Bernie Innocenti]

On Fri, 2010-10-22 at 04:19 +0530, Manusheel Gupta wrote:


> Please us know if the patch meets the requirements. If yes, can we add
> the documentation of the approach followed by us at the wiki?

If we're still taking about the v5 patch that was posted to the list, I
don't understand how this change is supposed to fix the bug:

 +        if self._count > 2:
 +           self.update()
 +        self._count = self._count + 1

Skipping the first frame of the animation unconditionally is wrong and
isn't the same thing of skipping frames dynamically, based on the time
elapsed to render  the previous frame. I feel like we're trying a number
of random tweaks without addressing the root cause of the problem.

Perhaps Anurag could work on a fix in team with other Seeta developers?

-- 
   // Bernie Innocenti - http://codewiz.org/
 \X/  Sugar Labs       - http://sugarlabs.org/