[Dextrose] [PATCH v4 sugar] Downgrading activities not allowed. (#2164)
bernie at codewiz.org
Sat Oct 16 16:31:18 EDT 2010
On Sun, 2010-10-17 at 01:55 +0530, anubhav at seeta.in wrote:
> + def __install_cancel_cb(self, button):
> + '''The opener will listen on the destroy signal
> + '''
> + logging.debug('1')
> + self.destroy()
> + def __install_ok_cb(self, button):
> + logging.debug('2')
...and this, are probably leftovers from your debugging sessions.
Please, remember to remove them before committing the patch.
> - def install(self, bundle, uid=None):
> + def install(self, bundle, uid=None,force_downgrade=False):
There should be a space after the comma.
> elif bundle.get_bundle_id() == installed_bundle.get_bundle_id():
> self.uninstall(installed_bundle, force=True)
> install_dir = env.get_user_activities_path()
Here you're adding a bunch of invisible spaces. Perhaps you could
configure your text editor to display spacing errors.
(This is not intended to be a full review, just a few things I've
spotted while scrolling through the patch. Please wait for a maintainer
to comment on the rest of the patch).
// Bernie Innocenti - http://codewiz.org/
\X/ Sugar Labs - http://sugarlabs.org/
More information about the Dextrose