[Dextrose] [Sugar-devel] [PATCH] Feature Request added : Kill the Mute function by clicking on the speaker icon.

[Martin Dengler]

On Mon, Nov 15, 2010 at 11:09:08AM -0500, Bernie Innocenti wrote:
> On Mon, 2010-11-15 at 15:19 +0000, Martin Dengler wrote:
> > On Sat, Nov 13, 2010 at 05:38:14PM +0530, shanjit at seeta.in wrote:
> > > From: Shanjit Singh Jajmann <shanjit at seeta.in>
> > > 
> > > Muting by clicking on the icon is killed.
> > 
> > NAK.  This functionality was requested by a deployment[1], AFAICS.
> 
> I just spoke on IRC with the original requester, Raul.
> 
> He says that the feature seemed cool, but it was developed before the
> roll-out so it could not be tested on actual users.
[...]
> So my proposal is: let's just remove this feature until someone comes up
> with a better way to implement it and justification for its usefulness.

I'm ok with this.  Let's do it properly:

0. figure out if this is intended behaviour and why - Shanjit, please
   include this information in a pre- or post- patch email next time
   so we don't have to waste time and you can demonstrate you know
   what you're changing.

1. bug report - Shanjit, please do this like [1] and include the
   information from 0.  Please remove
   http://wiki.sugarlabs.org/go/Kill_the_mute_function_in_the_volume_icon_of_the_frame
   as a) the page doesn't tell me any information from point 0 above;
   b) the page doesn't tell me who requested it; c) requires much less
   discussion than a "feature"; d) is much smaller in scope (code
   changes, UI effects, difficulty to revert) than a "feature"; and e)
   has no relation to a "feature"
   http://wiki.sugarlabs.org/go/Features/Policy#What_is_a_feature.3F
   as we usually use the term.

2. ...that includes which deployment, why, and HIG changes - Shanjit,
   please do this like [2]

3. test cases - Shanjit, please do this like [3]

4. run pylint / pep08 /tools on patch - Shanjit, please do this as in [1]

Shanjit, please read
http://wiki.sugarlabs.org/go/Development_Team/Code_Review#Proposal for
next time.

Martin

1. http://dev.laptop.org/ticket/7730

2. https://dev.laptop.org/ticket/7248

3. https://dev.laptop.org/ticket/7248#comment:7

4.  http://wiki.sugarlabs.org/go/Development_Team/Code_guidelines#Tools

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 190 bytes
Desc: not available
URL: <http://lists.sugarlabs.org/archive/dextrose/attachments/20101115/93c55166/attachment.pgp>