[Dextrose] [Sugar-devel] [PATCH V3] Copying files multiple times results in bogus names. (SL#2060)

Daniel Drake dsd at laptop.org
Sat Nov 13 12:37:16 EST 2010

On 13 November 2010 11:41,  <shanjit at seeta.in> wrote:
> From: Shanjit Singh Jajmann <shanjit at seeta.in>
> For every existing file copied to the location, the names are explicitly
> changed to filename_copynumber.extension e.g. games_1.png, games_2.png,
> games_3.jpg and so on.
> ---
> v1 -> v2. Parenthesis idea removed, i initialised from 1.
> Recommendations by Gonzalo Odiard, James Cameron and Martin Dengler added.

You still missed my point. And anything after "---" gets removed in
the commit message.

My point is that this patch is written by Gonzalo Odiard. You can see
it clearly in this email thread on November 10th.
Therefore the first line of your patch should be:

From: Gonzalo Odiard <gonzalo at laptop.org>

It's still OK for you to submit the patch even though you didn't write
it, and Gonzalo would probably even appreciate you taking on the role
of submission, but its important that you put the correct authorship.


More information about the Dextrose mailing list