[Dextrose] [Sugar-devel] Request to review solution for SL #2464

[James Cameron]

On Tue, Nov 09, 2010 at 02:33:02AM -0300, Gonzalo Odiard wrote:
> I have uploaded a new xo to http://dev.laptop.org/~gonzalo/Paint-29.xo
> I don't have a 0.82 system, can anybody confirm if is working ok?

Tested on freshly installed XO-1 OLPC OS 8.2.1 build gg-802-1, Sugar
0.82.1, and it starts okay.  This addresses the problem in SL #2464.

I was able to draw, quit, and then restore the drawing.

There were no unusual messages in the log.  Attached.

Also checked that it is essentially the same as git master for Paint,
except for the activity.info file version line.

Reviewed the changes from activities.sugarlabs.org Paint-28 and your
Paint-29 ... apart from the code changes, the other interesting things
were:

- MANIFEST is present in -29, not in -28, (is it needed?),
- a patch file is present in -28, not in -29, (this is good),
- .gitignore present in -28, not in -29, (this is good),
- fill/linux32_27 was added in -29, (this is good).

Well done.

-- 
James Cameron
http://quozl.linux.org.au/
-------------- next part --------------
reserved credentials (10000, 10003)
adding group: /usr/sbin/groupadd -o -g 10003 10003
adding user: /usr/sbin/useradd -m -u 10000 -g 10003 -c org.laptop.Oficina.10000 -d /home/olpc/isolation/1/uid_to_home_dir/10000 10000
dropping privilege to (10000, 10003)
chdir to /home/olpc/Activities/Paint.activity
umask(0)
about to execve
argv: dbus.Array([dbus.UTF8String('sugar-activity'), dbus.UTF8String('OficinaActivity.OficinaActivity'), dbus.UTF8String('-b'), dbus.UTF8String('org.laptop.Oficina'), dbus.UTF8String('-a'), dbus.UTF8String('dc28c6e2c59760ad3f42c38b32a866ce630678b1')], signature=dbus.Signature('s'))
env: dbus.Dictionary({dbus.UTF8String('LOGNAME'): dbus.UTF8String('olpc'), 'USER': '10000', dbus.UTF8String('HOME'): '/home/olpc/isolation/1/uid_to_home_dir/10000', dbus.UTF8String('PATH'): dbus.UTF8String('/home/olpc/Activities/Paint.activity/bin:/usr/share/sugar/activities/Journal.activity/bin:/usr/bin:/bin'), dbus.UTF8String('DISPLAY'): dbus.UTF8String(':0'), dbus.UTF8String('LANG'): dbus.UTF8String('en_US.UTF-8'), dbus.UTF8String('SHELL'): dbus.UTF8String('/bin/bash'), dbus.UTF8String('TZ'): dbus.UTF8String('UTC'), dbus.UTF8String('XDG_SESSION_COOKIE'): dbus.UTF8String('591015299d3b97d577e6b7a94cd8ee39-1289285215.552357-1845020383'), dbus.UTF8String('SESSION_MANAGER'): dbus.UTF8String('local/unix:@/tmp/.ICE-unix/1403,unix/unix:/tmp/.ICE-unix/1403'), dbus.UTF8String('SHLVL'): dbus.UTF8String('1'), dbus.UTF8String('ICEAUTHORITY'): '/home/olpc/isolation/1/uid_to_home_dir/10000/.ICEauthority', dbus.UTF8String('WINDOWPATH'): dbus.UTF8String('3'), dbus.UTF8String('SUGAR_BUNDLE_NAME'): dbus.UTF8String('Journal'), dbus.UTF8String('SUGAR_BUNDLE_PATH'): dbus.UTF8String('/home/olpc/Activities/Paint.activity'), dbus.UTF8String('SUGAR_LOCALEDIR'): dbus.UTF8String('/home/olpc/Activities/Paint.activity/locale'), dbus.UTF8String('SUGAR_THEME'): dbus.UTF8String('sugar-xo'), dbus.UTF8String('SUGAR_ACTIVITY_ROOT'): '/home/olpc/isolation/1/uid_to_home_dir/10000', dbus.UTF8String('GTK2_RC_FILES'): dbus.UTF8String('/usr/share/sugar/data/sugar-xo.gtkrc'), dbus.UTF8String('SUGAR_BUNDLE_ID'): dbus.UTF8String('org.laptop.Oficina'), dbus.UTF8String('DBUS_SESSION_BUS_ADDRESS'): dbus.UTF8String('unix:path=/tmp/olpc-session-bus,guid=38d390a032b15bf3e602bf6c4cd8ee5f'), 'TMPDIR': '/home/olpc/isolation/1/uid_to_home_dir/10000/tmp', dbus.UTF8String('XAUTHORITY'): '/home/olpc/isolation/1/uid_to_home_dir/10000/.Xauthority', dbus.UTF8String('GTK_IM_MODULE'): dbus.UTF8String('gtk-im-context-simple'), dbus.UTF8String('XSERVERAUTH'): dbus.UTF8String('/var/tmp/olpc-auth/.Xserverauth'), dbus.UTF8String('PWD'): dbus.UTF8String('/home/olpc'), dbus.UTF8String('SUGAR_BUNDLE_VERSION'): dbus.UTF8String('101')}, signature=dbus.Signature('ss'))
closing all fds but (1, 2)
{dbus.UTF8String('LOGNAME'): dbus.UTF8String('olpc'), 'USER': '10000', 'PATH': dbus.UTF8String('/home/olpc/Activities/Paint.activity/bin:/usr/share/sugar/activities/Journal.activity/bin:/usr/bin:/bin'), dbus.UTF8String('HOME'): '/home/olpc/isolation/1/uid_to_home_dir/10000', 'DISPLAY': dbus.UTF8String(':0'), 'LANG': dbus.UTF8String('en_US.UTF-8'), 'TERM': 'linux', dbus.UTF8String('SHELL'): dbus.UTF8String('/bin/bash'), dbus.UTF8String('TZ'): dbus.UTF8String('UTC'), 'XAUTHORITY': '/home/olpc/isolation/1/uid_to_home_dir/10000/.Xauthority', dbus.UTF8String('SESSION_MANAGER'): dbus.UTF8String('local/unix:@/tmp/.ICE-unix/1403,unix/unix:/tmp/.ICE-unix/1403'), dbus.UTF8String('SHLVL'): dbus.UTF8String('1'), 'ICEAUTHORITY': '/home/olpc/isolation/1/uid_to_home_dir/10000/.ICEauthority', dbus.UTF8String('WINDOWPATH'): dbus.UTF8String('3'), dbus.UTF8String('SUGAR_BUNDLE_NAME'): dbus.UTF8String('Journal'), dbus.UTF8String('SUGAR_BUNDLE_PATH'): dbus.UTF8String('/home/olpc/Activities/Paint.activity'), dbus.UTF8String('SUGAR_LOCALEDIR'): dbus.UTF8String('/home/olpc/Activities/Paint.activity/locale'), dbus.UTF8String('SUGAR_THEME'): dbus.UTF8String('sugar-xo'), 'UPSTART_JOB': 'rainbow', 'UPSTART_JOB_ID': '3', dbus.UTF8String('SUGAR_BUNDLE_ID'): dbus.UTF8String('org.laptop.Oficina'), 'DBUS_SESSION_BUS_ADDRESS': dbus.UTF8String('unix:path=/tmp/olpc-session-bus,guid=38d390a032b15bf3e602bf6c4cd8ee5f'), 'TMPDIR': '/home/olpc/isolation/1/uid_to_home_dir/10000/tmp', dbus.UTF8String('XDG_SESSION_COOKIE'): dbus.UTF8String('591015299d3b97d577e6b7a94cd8ee39-1289285215.552357-1845020383'), dbus.UTF8String('GTK_IM_MODULE'): dbus.UTF8String('gtk-im-context-simple'), dbus.UTF8String('XSERVERAUTH'): dbus.UTF8String('/var/tmp/olpc-auth/.Xserverauth'), dbus.UTF8String('SUGAR_ACTIVITY_ROOT'): '/home/olpc/isolation/1/uid_to_home_dir/10000', dbus.UTF8String('PWD'): dbus.UTF8String('/home/olpc'), dbus.UTF8String('SUGAR_BUNDLE_VERSION'): dbus.UTF8String('101'), 'UPSTART_EVENT': 'started', 'GTK2_RC_FILES': dbus.UTF8String('/usr/share/sugar/data/sugar-xo.gtkrc')}
/usr/lib/python2.5/site-packages/sugar/graphics/combobox.py:93: PangoWarning: error opening config file '/root/.pangorc': Permission denied

  self._model.append([action_id, text, pixbuf, False])
1289285623.393202 WARNING root: No gtk.AccelGroup in the top level window.
1289285623.456390 WARNING root: No gtk.AccelGroup in the top level window.
** (rainbow-daemon:1335): DEBUG: Got client ID "1070f302218a7d97ec128928562665946700000014030002"
** (rainbow-daemon:1335): DEBUG: Setting initial properties
** (rainbow-daemon:1335): DEBUG: Received SaveYourself(SmSaveLocal, !Shutdown, SmInteractStyleNone, !Fast) in state idle
** (rainbow-daemon:1335): DEBUG: Sending SaveYourselfDone(True) for initial SaveYourself
** (rainbow-daemon:1335): DEBUG: Received SaveComplete message in state save-yourself-done
1289285683.214727 WARNING root: No gtk.AccelGroup in the top level window.
1289285683.218433 WARNING root: No gtk.AccelGroup in the top level window.