[Dextrose] NamingAlert being optional

Anish Mangal anishmangal2002 at gmail.com
Wed Nov 3 15:09:46 EDT 2010


My two cents on this...


+        <long>If TRUE NamingAlert will show when
+        the activity close.</long>

s/If TRUE/If TRUE,/  (comma)



-        if skip_save or self._jobject is None or \
+        client = gconf.client_get_default()
+        show_alert = client.get_bool('/desktop/sugar/show_naming_alert')

/me being nitpicky, but perhaps show_naming_alert would be a better
variable name as compared so show_alert

Also, don't know if the commit title message could be better. "Add
show_naming_alert gconf key" or something like that instead of "S
non-intrusive NamingAlert"

On Wed, Nov 3, 2010 at 4:06 AM, Martin Abente
<martin.abente.lahaye at gmail.com> wrote:
> Hello amigos,
> I keep following the dextrose TODO list [1]. This time I made simple patches
> to make NamingAlert (the details popup that appears when the activity
> closes) optional.
> These patches should cleanly apply to Dextrose code base.
> 0001-S-non-intrusive-NamingAlert.patch applies to sugar.
> 0001-STK-non-intrusive-NamingAlert.patch applies to sugar-toolkit
> This is a review request :)
> 1 .http://wiki.sugarlabs.org/go/Dextrose/TODO
> _______________________________________________
> Dextrose mailing list
> Dextrose at lists.sugarlabs.org
> http://lists.sugarlabs.org/listinfo/dextrose


More information about the Dextrose mailing list