[Bugs] #2974 Sugar LOW: Resuming journal entries may cause Sugar to falsely report failed activity launch

[Sugar Labs Bugs]

#2974: Resuming journal entries may cause Sugar to falsely report failed activity
launch
--------------------------+-------------------------------
  Reporter:  greenfeld    |            Owner:  erikos
      Type:  defect       |           Status:  assigned
  Priority:  Low          |        Milestone:  Unspecified
 Component:  Sugar        |          Version:  0.92.x
  Severity:  Unspecified  |       Resolution:
  Keywords:               |  Distribution/OS:  OLPC
Bug Status:  Unconfirmed  |
--------------------------+-------------------------------
\
\
\
\
\
\

Comment (by quozl):

 In Sugar 0.104.1 this works by scheduling a 90 second timeout in
 ''notify_launch'' method of ''ShellModel''.  The source id of the timeout
 is not kept, so there's no way it can be cancelled.

 At the expiry of the timeout, ''_check_activity_launched'' is called; if
 the activity has been closed already, nothing is done.  But if there is a
 launcher for the same activity id (which will happen if it is a resume
 from journal), then a launch failure will be reported spuriously.

 A fix could be to delete the timeout if another instance is being started,
 or detect the process exit status, and delete the timeout.
\
\
\

--
Ticket URL: <http://bugs.sugarlabs.org/ticket/2974#comment:8>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system