[Bugs] #4841 Sugar NORM: Only some newly installed system-wide activities are favorites

[Sugar Labs Bugs]

#4841: Only some newly installed system-wide activities are favorites
---------------------+-------------------------------------
  Reporter:  quozl   |            Owner:
      Type:  defect  |           Status:  new
  Priority:  Normal  |        Milestone:
 Component:  Sugar   |          Version:  Git as of bugdate
  Severity:  Minor   |       Resolution:
  Keywords:          |  Distribution/OS:  Ubuntu
Bug Status:  New     |
---------------------+-------------------------------------
\
\
\
\
\
\

Comment (by quozl):

 Thanks,
 [https://github.com/tchx84/sugar/commit/28261e47e65e6fdd8c62b55ec6714c3378a1d3f8
 28261e4] on 'try5 seems to work better, but one remaining problem which
 may have already been present.  See test case !#4 below.
 ----
 Test case !#1, with the Terminal activity, not a favourite:

 * observe Sugar home view,
 * remove the package for the activity,
 * observe Sugar home view,
 * install the package for the activity,
 * observe Sugar home view,

 Expected result: no change to activities shown.  Pass.
 ----
 Test case !#2, with the Speak activity, a favourite:

 * observe Sugar home view,
 * remove the package for the activity,
 * observe Sugar home view,
 * reinstall the package for the activity,
 * observe Sugar home view,

 Expected result: the activity disappears from the home view when the
 package is removed, and reappears when the package is reinstalled.  Pass.
 ----
 Test case !#3, with the Sugar home view visible, SSH in from another
 system, then remove all activity packages:
 {{{
 apt remove \
 $(dpkg-query -W|grep sugar|grep activity|cut -f1 -d'        ')
 }}}

 Expected result: activities are slowly removed from the view, leaving only
 activities that are installed in $HOME (if any).  Pass.
 ----
 Test case !#4, with the Sugar home view visible, SSH in from another
 system, then install all activity packages;
 {{{
 apt install olpc-activities
 }}}

 Expected result: activities are slowly added to the view, with all
 activities shown once the install completes.  Fail.

 Observed result: while many activities do appear, not all of them do.

 Whether an activity appears depends on some random element;
 * first try: Abacus, Calculate, Chart, Clock, Distance, FotoToon,
 FractionBounce, Gears, Image Viewer, Implode, Jukebox, Letters, Maze,
 Memorize, Moon, Physics, Poll, Portfolio, Read, Record, StopWatch, and
 Write.
 * second try: Abacus, Calculate, Chart, Clock, Distance, FotoToon,
 FractionBounce, Gears, Image Viewer, Jukebox, Letters, Maze, Measure,
 Memorize, Paint, Poll, Read, Record, StopWatch, Terminal, and Write.

 All activities are shown after a restart of Sugar.

 My guess is that there is a [https://en.wikipedia.org/wiki/Race_condition
 race condition].
\
\
\

--
Ticket URL: <http://bugs.sugarlabs.org/ticket/4841#comment:16>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system