[Bugs] #4841 Sugar NORM: Only some newly installed system-wide activities are favorites

[Sugar Labs Bugs]

#4841: Only some newly installed system-wide activities are favorites
---------------------+-------------------------------------
  Reporter:  quozl   |            Owner:
      Type:  defect  |           Status:  new
  Priority:  Normal  |        Milestone:
 Component:  Sugar   |          Version:  Git as of bugdate
  Severity:  Minor   |       Resolution:
  Keywords:          |  Distribution/OS:  Ubuntu
Bug Status:  New     |
---------------------+-------------------------------------
\
\
\
\
\
\

Comment (by tch):

 Replying to [comment:14 quozl]:
 > Thanks!
 >

 Thank you for testing it.

 > Tested, with removing and reinstalling Terminal using apt; Terminal was
 shown in the activity ring when it should not have been.
 >

 I have addressed the comments from your email.

 The issue was that I only covered (by design) the equivalent scenario for
 processing defaults, so the hidden list was only applied during shell
 start up. The shell already favorite all the activities when they are
 installed, my patches did not modify that.

 Now [1], I also covered that other scenario for when activities are copied
 directly to the activities directories or via journal at run-time, so the
 hidden list is also taken into account then.

 Please a have a look [2].

 [1] https://github.com/tchx84/sugar/commits/enhance-favorites-try5
 [2]
 https://github.com/tchx84/sugar/commit/28261e47e65e6fdd8c62b55ec6714c3378a1d3f8

 >
 >shell.log contained a traceback:
 > {{{
 > Traceback (most recent call last):
 >   File "/usr/lib/python2.7/dist-
 packages/jarabe/model/bundleregistry.py", line 136, in
 __file_monitor_changed_cb
 >     self.add_bundle(one_file.get_path(), set_favorite=True)
 >   File "/usr/lib/python2.7/dist-
 packages/jarabe/model/bundleregistry.py", line 281, in add_bundle
 >     bundle_id = bundle.get_bundle_id()
 > AttributeError: 'NoneType' object has no attribute 'get_bundle_id'
 > }}}
 >

 I have tried to reproduce this but couldn't (using Fedora 21 and sugar-
 build).

 The weird thing is that the error appears in a execution path that is not
 related to the changes of version you tried. The hidden file processing
 happened only during shell start up nothing in "add_bundle" should be
 affected by that, specially not the parsing of the bundle files.

 There is definitely something wrong (as the logs shows), but would be good
 to confirm this is unrelated to this changes. Have you tried reproducing
 it without the changes?

 I would not be surprised there are other issues. I solved another while I
 was improving my previous changes [3], which I think it happens to be what
 German mentioned the other day.

 [3]
 https://github.com/sugarlabs/sugar/commit/a489eae29fce1c9d29515211c02a62da352f31e0

 > Further detail sent by private mail.
\
\
\

--
Ticket URL: <http://bugs.sugarlabs.org/ticket/4841#comment:15>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system