[Bugs] #3968 Browse NORM: Clear URL entry icon should disappear when there is no text

[Sugar Labs Bugs]

#3968: Clear URL entry icon should disappear when there is no text
----------------------------------------+-----------------------------------
    Reporter:  humitos                  |          Owner:  humitos    
        Type:  defect                   |         Status:  closed     
    Priority:  Normal                   |      Milestone:  1.0        
   Component:  Browse                   |        Version:  Unspecified
    Severity:  Unspecified              |     Resolution:  fixed      
    Keywords:  gtk3, 13.1.0, patch, r+  |   Distribution:  Unspecified
Status_field:  Unconfirmed              |  
----------------------------------------+-----------------------------------
Changes (by manuq):

  * keywords:  gtk3, 13.1.0, patch, r? => gtk3, 13.1.0, patch, r+
  * status:  new => closed
  * resolution:  => fixed


Comment:

 I found this with case the patch didn't solve:

 - focus the entry, remove all text --> X icon disappears
 - focus the page
 - focus the entry again --> X icon appears again

 Repatch:

 {{{
 --- a/webtoolbar.py
 +++ b/webtoolbar.py
 @@ -432,7 +432,10 @@ class PrimaryToolbar(ToolbarBase):

      def __focus_in_event_cb(self, entry, event):
          if not self._tabbed_view.is_current_page_pdf():
 -            self._show_clear_icon()
 +            if not self.entry.props.text:
 +                self._show_no_icon()
 +            else:
 +                self._show_clear_icon()
 }}}

 Repatched and pushed as 58f06e27

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/3968#comment:4>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system