[Bugs] #4384 Browse UNSP: Browse: display a message while downloading a PDF

[Sugar Labs Bugs]

#4384: Browse: display a message while downloading a PDF
------------------------------------------+---------------------------------
    Reporter:  manuq                      |          Owner:  manuq      
        Type:  enhancement                |         Status:  new        
    Priority:  Unspecified by Maintainer  |      Milestone:  1.0        
   Component:  Browse                     |        Version:  Unspecified
    Severity:  Unspecified                |       Keywords:  r?         
Distribution:  Unspecified                |   Status_field:  Unconfirmed
------------------------------------------+---------------------------------

Comment(by manuq):

 Thanks humitos.

 Replying to [comment:3 humitos]:
 > I have some minor comments about your patches:
 >
 >  * sugar-toolkit-gtk3: set the default value for direction in the
 argument instead of using None and then check if that argument is None:

 There are important reasons to not use mutable objects as default
 parameters in Python:

 http://effbot.org/zone/default-values.htm

 >  * browse: I don't like (personal opinion) the use of
 {{{self.get_children()[0]}}} because if later we add a new child to
 PDFTabPage maybe the PDFMessageBox is not in the [0] position anymore. I
 prefer using {{{self.message_box = PDFMessageBox}}}.

 Good, I will change it to a private property, _message_box (name starting
 with a '_').

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/4384#comment:4>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system