[Bugs] #4010 sugar-artwork NORM: Theme: check why not all stock icons are available

[Sugar Labs Bugs]

#4010: Theme: check why not all stock icons are available
------------------------------+---------------------------------------------
    Reporter:  erikos         |          Owner:  manuq                        
        Type:  defect         |         Status:  assigned                     
    Priority:  Normal         |      Milestone:  1.0                          
   Component:  sugar-artwork  |        Version:  0.97.x                       
    Severity:  Major          |       Keywords:  13.1.0, theme, regression, r?
Distribution:  OLPC           |   Status_field:  Assigned                     
------------------------------+---------------------------------------------
Changes (by manuq):

 * cc: erikos (added)
  * keywords:  13.1.0, theme, regression => 13.1.0, theme, regression, r?
  * milestone:  0.98 => 1.0


Comment:

 We are missing gtk-ok.svg .  The stock icons are named by convention with
 the same name as the stock id [1].  For Gtk.STOCK_OK it is 'gtk-ok' [2].

 [1] http://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#gtk3
 -Stock-Items.description
 [2] http://developer.gnome.org/gtk3/stable/gtk3-Stock-Items.html#GTK-
 STOCK-OK:CAPS

 We can add gtk-ok.svg as a symbolic link to dialog-ok.svg .  The same is
 for gtk-cancel.svg, it is a symbolic link to dialog-cancel.svg .  The
 attached patch for artwork does so.

 Unlike gtk-cancel, we have to do the link manually in the Makefile.  The
 gtk-cancel link is done by the utility icon-naming-utils, a dependency of
 sugar-artwork.  It provides various aliases for
 backwards compatibility.  In /usr/share/icon-naming-utils/legacy-icon-
 mapping.xml there is an entry
 for dialog-cancel:

 {{{
         <icon name="dialog-cancel">
             <link>gtk-cancel</link>
             <link>button_cancel</link>
             <link>cancel</link>
         </icon>
 }}}

 But there is no entry for dialog-ok.

 The confusion in #3971 was that the icon theme is not updated after we
 copy the svg file to the corresponding directory.  We need to touch the
 directory for that to happen:

 {{{
 sudo touch /usr/share/icons/sugar/
 }}}

 After that the icon appears.  The attached testcase will tell if the
 custom icon is found or not.  Run it from a sugar shell, like from
 Terminal activity.

 The change made in #3971 can be reverted after this fix.  I attach a
 revert patch too.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/4010#comment:4>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system