[Bugs] #4318 sugar-artwork NORM: Frame clippings palette needs GTK3 theme updates

[Sugar Labs Bugs]

#4318: Frame clippings palette needs GTK3 theme updates
------------------------------+---------------------------------------------
    Reporter:  garycmartin    |          Owner:  manuq      
        Type:  defect         |         Status:  new        
    Priority:  Normal         |      Milestone:  0.98       
   Component:  sugar-artwork  |        Version:  0.98.x     
    Severity:  Unspecified    |       Keywords:  regression 
Distribution:  Unspecified    |   Status_field:  Unconfirmed
------------------------------+---------------------------------------------

Comment(by manuq):

 The case is, we need to properly style the Gtk.Menu implementation of our
 palettes.

 The two implementations live in palettewindow.py.  There are: class
 _PaletteMenuWidget, which inherits Gtk.Menu, and class
 _PaletteWindowWidget, which inherits Gtk.Window.

 I tried to add an outline to the Gtk.Menu one, doing the same as the
 Gtk.Window one, reimplement the
 do_draw method like this:

 - call the parent's class do_draw
 - if the palette has an invoker (is attached to a button), calculate the
 gap between the two widgets
 - then call Gtk.render_frame_gap or Gtk.render_frame
 - the theme takes care of the styling of that frame

 The problem is that Gtk.Menu.do_draw already calls Gtk.render_frame:

 http://git.gnome.org/browse/gtk+/tree/gtk/gtkmenu.c#n3046

 Then, an unwanted line can be seen between the button and the palette,
 like in [http://bugs.sugarlabs.org/attachment/ticket/4318/clipboard-
 palette.png humitos attachment].

 I attach my patch for the sake of future improvement.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/4318#comment:2>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system