[Bugs] #3868 Browse NORM: Bookmarks toolbar does not appear when bookmark is created

[Sugar Labs Bugs]

#3868: Bookmarks toolbar does not appear when bookmark is created
----------------------------+-----------------------------------------------
    Reporter:  greenfeld    |          Owner:  humitos
        Type:  defect       |         Status:  closed 
    Priority:  Normal       |      Milestone:  0.98   
   Component:  Browse       |        Version:  0.97.x 
    Severity:  Unspecified  |     Resolution:  fixed  
    Keywords:  patch        |   Distribution:  OLPC   
Status_field:  Assigned     |  
----------------------------+-----------------------------------------------
Changes (by manuq):

  * status:  assigned => closed
  * resolution:  => fixed


Comment:

 I've found the following issues with your patch:

 Removing the last bookmark leaves the tray opened and the tray icon is
 greyed out so you can't hide it manually.  Testcase:

 - start browse from scratch
 - add a bookmark, tray appears
 - remove bookmark (from bookmark palette)

 And:

 button graphics are inverted, up arrow should hide the tray, and down
 arrow should show the tray.

 So starting with your patch I inverted the way things are done:

 Instead of changing the tooltip and icon of the tool button based on the
 visibility of the tray, with the map and unmap callbacks that this patch
 removes, do the inverse: when a bookmark is made, the toggle button is
 activated, and it shows the tray in the toggled callback.  Also when the
 only pending bookmark is removed, the toggle button is deactivated, and it
 hides the tray in the toggled callback.

 The switch to a toggle button allows us to do the tray and button
 interaction in a more standard way, and the bugs that the unconventional
 interaction raised are now fixed.

 Pushed it as 49495aa4, thanks.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/3868#comment:7>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system