[Bugs] #3553 Browse NORM: Display only the url in the url entry
Sugar Labs Bugs
bugtracker-noreply at sugarlabs.org
Fri Sep 28 01:25:43 EDT 2012
#3553: Display only the url in the url entry
--------------------------------------+-------------------------------------
Reporter: erikos | Owner: humitos
Type: enhancement | Status: closed
Priority: Normal | Milestone: 0.98
Component: Browse | Version: Git as of bugdate
Severity: Unspecified | Resolution: fixed
Keywords: 12.2.0, design, patch | Distribution: OLPC
Status_field: Unconfirmed |
--------------------------------------+-------------------------------------
Changes (by manuq):
* status: accepted => closed
* resolution: => fixed
Comment:
Replying to [comment:3 humitos]:
> I had to add a new property in Browse class to save the url entered by
the user. This is because if we switch over the tabs we will get a None
uri if the page can not be loaded yet.
>
> So, I'm saving the {{{effective_url}}} in this property
({{{loading_url}}}) and I'm showing it if {{{browser.pops.uri}}} is None.
Good, but I think the gobject property is unnecessary, using a
conventional python class attribute instead is fine. I pushed it with
this change as 5d018839 . Thanks!
--
Ticket URL: <http://bugs.sugarlabs.org/ticket/3553#comment:5>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system
More information about the Bugs
mailing list