[Bugs] #1434 Browse UNSP: Pressing Esc does not stop page load
Sugar Labs Bugs
bugtracker-noreply at sugarlabs.org
Wed Sep 19 08:40:31 EDT 2012
#1434: Pressing Esc does not stop page load
------------------------------------------+---------------------------------
Reporter: benzea | Owner: humitos
Type: defect | Status: accepted
Priority: Unspecified by Maintainer | Milestone: 0.98
Component: Browse | Version: Unspecified
Severity: Unspecified | Keywords: patch
Distribution: Unspecified | Status_field: Unconfirmed
------------------------------------------+---------------------------------
Comment(by manuq):
Replying to [comment:8 humitos]:
> Replying to [comment:4 garycmartin]:
> > Something like 1) if in fullscreen mode and a page is not loading,
exit fullscreen mode; 2) if in fullscreen mode and a page is loading, stop
loading -- this is how Safari handles the esc case.
>
> Well, this is not so easy to do because in that case we have to modify
the Activity class to handle this situation. In fact, I think it's not a
good idea to modify the Activity class just for this special situation.
Maybe we can think in something more general like defining a "state"
(boolean) variable to add in the if clause.
Remember classes and inheritance? :P You can redefine the callback (as we
did in Terminal some months ago #440) Just remember to call the parent's
callback. Is a bit hackish because is a private method and have the name
mangling with the two underscores, but I think doable.
--
Ticket URL: <http://bugs.sugarlabs.org/ticket/1434#comment:9>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system
More information about the Bugs
mailing list