[Bugs] #946 Browse NORM: Can not download image when opened in a popup

Sugar Labs Bugs bugtracker-noreply at sugarlabs.org
Tue Sep 11 14:00:23 EDT 2012


#946: Can not download image when opened in a popup
----------------------------+-----------------------------------------------
    Reporter:  erikos       |          Owner:  erikos
        Type:  enhancement  |         Status:  new   
    Priority:  Normal       |      Milestone:  0.98  
   Component:  Browse       |        Version:  0.84.x
    Severity:  Minor        |       Keywords:        
Distribution:  Unspecified  |   Status_field:  New   
----------------------------+-----------------------------------------------
Changes (by humitos):

 * cc: godiard, erikos (added)


Comment:

 This is the code we should use to look for {{{background-image}}}
 property, but we have to go throughout the DOM (from the inside to the top
 of it) to look that style property.

 In the example given in the previous comment, when I click over the image
 I get the "inner div", so I have to ask for the parent of it to check the
 {{{background-image}}} property:

 {{{
 >>> element = hit_test.props.inner_node
 >>> element.props.style.get_css_text()
 'position: relative; width: 700px; height: 525px; '
 >>> element.get_parent_element().props.style.get_css_text()
 'background-image: url(http://activities.sugarlabs.org/en-
 US/sugar/images/p/5/1235687644); display: block; '
 }}}

 So, do we want to make that check recursively to check that property? how
 deep do we want to make it?

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/946#comment:10>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system


More information about the Bugs mailing list