[Bugs] #3836 sugar-toolkit-gtk3 UNSP: Palette Icon: drawn with grey background

[Sugar Labs Bugs]

#3836: Palette Icon: drawn with grey background
------------------------------------------+---------------------------------
    Reporter:  erikos                     |          Owner:  erikos           
        Type:  defect                     |         Status:  new              
    Priority:  Unspecified by Maintainer  |      Milestone:  0.98             
   Component:  sugar-toolkit-gtk3         |        Version:  0.97.x           
    Severity:  Major                      |       Keywords:  shell-port 13.1.0
Distribution:  Fedora                     |   Status_field:  New              
------------------------------------------+---------------------------------

Comment(by manuq):

 The globals removal patch will remove the grey background square.  However
 we still have a greyish icon.  This is because in palette get_menu() we
 mark the menuitem as insensitive, if that line is removed we get the
 bright icon again:

 {{{
 --- a/src/sugar3/graphics/palette.py
 +++ b/src/sugar3/graphics/palette.py
 @@ -384,7 +384,6 @@ class Palette(PaletteWindow):
              # Mark the menuitem as insensitive so that it appears as an
              # informational element, rather than a clickable item in the
 menu.
              # TODO: see if we can do this better in GTK.
 -            self._label_menuitem.set_sensitive(False)

              self._label_menuitem.show()
              self._widget.append(self._label_menuitem)
 }}}


 Then at the icon, the _IconBuffer method _get_insensitive_pixbuf() is
 returning the greyed out graphic.

 If that menuitem is set insensitive because of styling, then if possible
 the insensitive should be removed and this should be done in the theme.  I
 was trying to do it (without success yet):

 {{{
 SugarPaletteMenuWidget .menuitem:prelight:first-child {
     background-color: transparent;
 }
 }}}

 Or an easier fix is add a custom gtype_name to style it.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/3836#comment:3>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system