[Bugs] #4025 sugar UNSP: Improve circle/spiral layout of favourite view to improve touch target size/spacing

[Sugar Labs Bugs]

#4025: Improve circle/spiral layout of favourite view to improve touch target
size/spacing
------------------------------------------+---------------------------------
    Reporter:  garycmartin                |          Owner:  manuq      
        Type:  enhancement                |         Status:  assigned   
    Priority:  Unspecified by Maintainer  |      Milestone:  0.98       
   Component:  sugar                      |        Version:  Unspecified
    Severity:  Unspecified                |       Keywords:  13.1.0, r? 
Distribution:  Unspecified                |   Status_field:  Unconfirmed
------------------------------------------+---------------------------------

Comment(by manuq):

 Great work Gary.

 This patch switches from fixed intermadiate sizes (the removed
 _INTERMEDIATE_* constants) to dynamic intermadiate sizes.  I think this is
 worth to mention in the commit message.  Is in the follow up patch I'm
 attaching.

 The new calculation in _calculate_radius_and_angle that involves a square
 root calculation is not trivial so I asked Gary for a comment in the code.
 In the follow up patch too.

 The while loops try sizes 1 pixel smaller for each loop.  This calls the
 square root calculation so I was worried about performance, but Gary said
 he tested and the layout time is not too much slower than
 the previous.

 This breaks the triangle and box layouts but by the way they are commented
 out in favoritesview.py .

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/4025#comment:6>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system