[Bugs] #4236 Browse NORM: Issue with popup window

[Sugar Labs Bugs]

#4236: Issue with popup window
----------------------------+-----------------------------------------------
    Reporter:  erikos       |          Owner:  humitos 
        Type:  defect       |         Status:  accepted
    Priority:  Normal       |      Milestone:  0.98    
   Component:  Browse       |        Version:  0.97.x  
    Severity:  Major        |       Keywords:  r?      
Distribution:  Unspecified  |   Status_field:  Assigned
----------------------------+-----------------------------------------------
Changes (by humitos):

 * cc: erikos, dnarvaez (added)
  * keywords:  => r?


Comment:

 Replying to [comment:6 erikos]:
 > The two examples I added above http://dev.laptop.org/~erikos/wanted.html
 and http://dev.laptop.org/~erikos/unwanted.html does work as expected on
 the XO. The former does open the new window in a new tab if I click on the
 button. The latter does block the popup window.

 Those examples use Javascript code ({{{window.open(url)}}}) to create a
 new window with the URL given. I understand that case is already managed
 by the signal: new-window-policy-decision-requested

  * http://webkitgtk.org/reference/webkitgtk/stable/webkitgtk-
 webkitwebview.html#WebKitWebView-new-window-policy-decision-requested

 > Now, the question is, why the packet example (dhl.de) does work in
 Epiphany but not in Browse.

 The site you mentioned here uses {{{target="_blank"}}} on its form and
 that is handled by(*): 'create-web-view' signal. That is the signal we are
 not handling.

 I've got a patch that I'm testing to be sure that it cover these cases.

 (*) I can't confirm that because I've just create an index.html to test
 that and it worked on build 13. I don't understand what is the difference
 between 'new-window-policy-decision-requested' and 'create-web-view'.
 Another reason could be some strange javascript connected to the submit
 button that I'm not seeing.

 Anyway, I'm uploading the patch that I have here tested on many cases to
 see if someone else find another case that it doesn't work or to take a
 look what I did.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/4236#comment:9>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system