[Bugs] #3895 sugar URGE: Tabbinghandler not working

[Sugar Labs Bugs]

#3895: Tabbinghandler not working
----------------------------+-----------------------------------------------
    Reporter:  erikos       |          Owner:  erikos        
        Type:  defect       |         Status:  new           
    Priority:  Urgent       |      Milestone:  0.98          
   Component:  sugar        |        Version:  0.97.x        
    Severity:  Blocker      |       Keywords:  regression, r?
Distribution:  Unspecified  |   Status_field:  Assigned      
----------------------------+-----------------------------------------------

Comment(by erikos):

 Replying to [comment:8 godiard]:
 > I have uploaded a new patch for review.
 >
 > This patch use the deprecated gdk-keyboard-grab, gdk-pointer-grab. Now I
 see it working, if we want, we can try use the new api.

 I have attached a patch with the new API. Works the same as yours. Both do
 not show the Frame when tabbing. This is because right after grabbing we
 ungrab again. We have to compare with the old code.

 Furthermore we should check how to handle the devices. Cache the keyboard
 device (like in my example patch)? Always request from new? How do we
 handle keyboards that are attached?

 > Is not clear for me, why we need grab the mouse.

 To me is not clear neither. Tested on 12.1.0 without grabbing the mouse
 and it worked as expected. We should ask Benzea if we miss anything.

 > Another strange issue (may be a bug a lower levels) is after testing a
 lot, I can see cases where the mask returned by window.get_pointer() is 0,
 then the keyboard and mouse are not ungrabed. I have modified the
 condition to ungrab in that situation too.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/3895#comment:9>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system