[Bugs] #3936 sugar-artwork HIGH: Grey rounded rect fill style of gtk3 Frame and Activity toolbar active and pressed icons too large

[Sugar Labs Bugs]

#3936: Grey rounded rect fill style of gtk3 Frame and Activity toolbar active and
pressed icons too large
------------------------------+---------------------------------------------
    Reporter:  garycmartin    |          Owner:  manuq            
        Type:  defect         |         Status:  assigned         
    Priority:  High           |      Milestone:  0.98             
   Component:  sugar-artwork  |        Version:  0.97.x           
    Severity:  Major          |       Keywords:  13.1.0, theme, r?
Distribution:  Unspecified    |   Status_field:  Unconfirmed      
------------------------------+---------------------------------------------

Comment(by garycmartin):

 Replying to [comment:6 manuq]:
 > Candidate patch attached.  I have verified this has the same margin as
 the GTK2 theme.  Two things worth mention:
 >
 > 1. as we are using a transparent border to get the margin, there is one
 state we can't get fully correct: an active button wich is being hovered.
 It should be a black fill below a light grey rounded button.
 >
 > 2. the code that draws an outline around the button when it has a
 palette, should be updated to consider the margin.

 Yes, I see both these issues as well, but otherwise I've not yet notices
 any other side effects in the Frame or Activities. Interestingly I could
 only get this to make a visible difference on an XO-1.75, it applied
 correctly to an XO-4 without error but has no visible difference – still
 investigating, must be something I'm doing (both are running 13.1.0 build
 16 with fresh git make/installs of toolkit, shell, artwork, plus this
 artwork patch and nothing else).

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/3936#comment:7>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system