[Bugs] #3818 sugar UNSP: Clipboard, drag&drop: notification icon is 'application-octet'

[Sugar Labs Bugs]

#3818: Clipboard, drag&drop: notification icon is 'application-octet'
------------------------------------------+---------------------------------
    Reporter:  erikos                     |          Owner:  erikos  
        Type:  defect                     |         Status:  new     
    Priority:  Unspecified by Maintainer  |      Milestone:  0.98    
   Component:  sugar                      |        Version:  0.97.x  
    Severity:  Critical                   |       Keywords:          
Distribution:  OLPC                       |   Status_field:  Assigned
------------------------------------------+---------------------------------

Comment(by erikos):

 When we drag&drop an object we do
 [http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/frame/clipboardtray.py#line184
 set the percentage to 100]. This creates the notification
 [http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/frame/clipboardicon.py#line137
 right at the beginning when the data type has not been determined yet].
 The clipboard_icon itself we
 [http://git.sugarlabs.org/sugar/mainline/blobs/master/src/jarabe/frame/clipboardicon.py#line123
 keep on updating] when the state changes.


 A fix would be to update the NotificationIcon as well when the state
 changes which passes my tests:

 {{{
 diff --git a/src/jarabe/frame/clipboardicon.py
 b/src/jarabe/frame/clipboardicon.py
 index ebf3ad1..4baf844 100644
 --- a/src/jarabe/frame/clipboardicon.py
 +++ b/src/jarabe/frame/clipboardicon.py
 @@ -121,6 +121,8 @@ class ClipboardIcon(RadioToolButton):

          if cb_object.get_icon():
              self._icon.props.icon_name = cb_object.get_icon()
 +            if self._notif_icon:
 +                self._notif_icon.props.icon_name =
 self._icon.props.icon_name
          else:
              self._icon.props.icon_name = 'application-octet-stream'
 }}}

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/3818#comment:1>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system