[Bugs] #3450 UNSP: Activity.__init__(..., create_jobject=False) broken

[Sugar Labs Bugs]

#3450: Activity.__init__(..., create_jobject=False) broken
------------------------------------------+---------------------------------
    Reporter:  sascha_silbe               |          Owner:  erikos                     
        Type:  defect                     |         Status:  new                        
    Priority:  Unspecified by Maintainer  |      Milestone:  Unspecified by Release Team
   Component:  sugar-toolkit              |        Version:  0.92.x                     
    Severity:  Major                      |       Keywords:  dx3                        
Distribution:                             |   Status_field:  Unconfirmed                
------------------------------------------+---------------------------------
 An Activity that doesn't have any useful state to save in the Journal and
 passes {{{create_jobject=False}}} to
 {{{sugar.activity.activity.Activity.__init__()}}} is bound to fail since
 Sugar 0.92.4 as [https://git.sugarlabs.org/sugar-
 toolkit/mainline/commit/6b675ed45f333b19706331021f474b16add1b084 6b675ed]
 resp. [https://git.sugarlabs.org/sugar-
 toolkit/mainline/commit/0269f819761cfd803cf4d694298c8ab6a753e242 0269f819]
 introduced unconditional accessing of {{{self._jobject}}}:

 {{{
 class Activity(Window, gtk.Container):
 [...]
     def __init__(self, handle, create_jobject=True):
 [...]
         self.set_title(self._jobject.metadata['title'])
 }}}

 Some later patches have introduced even more unconditional accessing of
 {{{self._jobject}}}.

 This is a regression and should be fixed in both sugar-toolkit-gtk3 and
 sugar-toolkit, including the (maintained) stable branches.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/3450>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system