[Bugs] #3405 UNSP: Read: when canceling the bookmark dialog I have to click twice the icon to reveal it again

[Sugar Labs Bugs]

#3405: Read: when canceling the bookmark dialog I have to click twice the icon to
reveal it again
------------------------------------------+---------------------------------
    Reporter:  erikos                     |          Owner:  godiard          
        Type:  defect                     |         Status:  closed           
    Priority:  Unspecified by Maintainer  |      Milestone:  0.96             
   Component:  Read                       |        Version:  Git as of bugdate
    Severity:  Major                      |     Resolution:  fixed            
    Keywords:  12.1.0, olpc-test-pending  |   Distribution:  OLPC             
Status_field:  Unconfirmed                |  
------------------------------------------+---------------------------------
Changes (by godiard):

  * keywords:  12.1.0 => 12.1.0, olpc-test-pending
  * status:  new => closed
  * resolution:  => fixed


Comment:

 The bug have two sources.

 First, the button used to add/remove the bookmark is a toggle, and the
 gtk3 theme is not setting the right grey color, then is not obvious to the
 user if the button is pressed or not.(this problem will be addressed in
 sugar-artwork)

 The second problem is, if the user cancel the dialog creating the
 bookmark, the bookmark is not created but the button continue pressed
 until the page is changed. This was solved sending a signal to update the
 button state.

 Two other problems were found and solved:

 * The page number in the bookmark description was wrong by one.

 * If the page had more than one bookmark, the clear method only removed
 the last then the sidebar accumulated bookmark icons.

 Fixed in 743f1428db484972a2a9e9ba3e85d97c66cb76f4

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/3405#comment:1>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system