[Bugs] #3066 UNSP: BrowseV124 regressions

Sugar Labs Bugs bugtracker-noreply at sugarlabs.org
Wed Aug 31 05:39:59 EDT 2011


#3066: BrowseV124 regressions
------------------------------------------+---------------------------------
    Reporter:  tonyforster                |          Owner:  lucian     
        Type:  defect                     |         Status:  new        
    Priority:  Unspecified by Maintainer  |      Milestone:  0.94       
   Component:  Browse                     |        Version:  Unspecified
    Severity:  Unspecified                |       Keywords:             
Distribution:  Unspecified                |   Status_field:  Unconfirmed
------------------------------------------+---------------------------------

Comment(by erikos):

 {{{
 diff --git a/palettes.py b/palettes.py
 index 9fbc370..a275f37 100644
 --- a/palettes.py
 +++ b/palettes.py
 @@ -77,8 +77,10 @@ class ContentInvoker(Invoker):

          target = event.target

 -        if target.tagName.lower() == 'a':
 +        if not (target.tagName.lower() == 'a' or target.tagName.lower()
 == 'img'):
 +            target = target.parentNode

 +        if target.tagName.lower() == 'a':
              if target.firstChild:
                  title = target.firstChild.nodeValue
              else:
 }}}

 The above would solve the issues above.

 I came across another issue that is in the same code path. Often an image
 and a link are nested. For example, see the picture of Leonardo on
 http://de.wikipedia.org/wiki/Da_Vinci and right click on it in Firefox.
 You will have the options to follow the link (new tab new window or copy
 it) or save the image. In Browse you can only save the image when using
 the palette.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/3066#comment:7>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system


More information about the Bugs mailing list