[Bugs] #2303 UNSP: unnecessary checkout for getting file size

Sugar Labs Bugs bugtracker-noreply at sugarlabs.org
Wed Sep 8 15:25:25 EDT 2010


#2303: unnecessary checkout for getting file size
------------------------------------------+---------------------------------
    Reporter:  sascha_silbe               |          Owner:  alsroot          
        Type:  defect                     |         Status:  new              
    Priority:  Unspecified by Maintainer  |      Milestone:  0.90             
   Component:  journal                    |        Version:  Git as of bugdate
    Severity:  Minor                      |       Keywords:                   
Distribution:                             |   Status_field:  Unconfirmed      
------------------------------------------+---------------------------------
 From jarabe.journal.expandedentry.ExpandedEntry._create_technical():

 {{{
              _('Size: %s') %
 (format_size(int(self._metadata.get('filesize',
 model.get_file_size(self._metadata['uid']))))),
 }}}

 {{{dict.get()}}} doesn't short-circuit evaluation, so
 {{{model.get_file_size()}}} will always get evaluated, even if
 {{{self._metadata}}} contains {{{filesize}}}.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/2303>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system


More information about the Bugs mailing list