[Bugs] #2228 URGE: add new telepathy dependencies to sugar-jhbuild

[Sugar Labs Bugs]

#2228: add new telepathy dependencies to sugar-jhbuild
------------------------------+---------------------------------------------
    Reporter:  tomeu          |          Owner:  sascha_silbe     
        Type:  enhancement    |         Status:  new              
    Priority:  Urgent         |      Milestone:                   
   Component:  sugar-jhbuild  |        Version:  Git as of bugdate
    Severity:  Blocker        |       Keywords:                   
Distribution:                 |   Status_field:  New              
------------------------------+---------------------------------------------
Changes (by sascha_silbe):

  * severity:  Unspecified => Blocker
  * priority:  Unspecified by Maintainer => Urgent
  * version:  Unspecified => Git as of bugdate
  * milestone:  Unspecified by Release Team =>
  * keywords:  r? =>
  * distribution:  Unspecified =>
  * status_field:  Unconfirmed => New


Comment:

 Thanks for working on this! Unfortunately there are a few issues with the
 patch:

 {{{
 --- a/config/modulesets/glucose-external-0.84.modules
 +++ b/config/modulesets/glucose-external-0.84.modules
 @@ -98,6 +98,9 @@
        <dep package="telepathy-glib"/>
        <dep package="dbus-glib"/>
        <dep package="libsoup"/>
 +      <dep package="sqlite3"/>
 +      <dep package="libuuid"/>
 +      <dep package="libnice"/>
 }}}

 You add source dependencies, but no build recipes for them. I suppose you
 wanted to add system (distro) dependencies instead. For that you'll need
 to modify the same files you removed telepathy-* from and use the exact
 package names for the specific distribution, including checking that the
 version shipped by the distribution suffices for building Telepathy.

 {{{
 +        # Make Mission Control 5 use our accounts dir
 +        accounts_dir = os.path.join(os.path.expanduser('~/.sugar'),
 +                                    os.environ.get('SUGAR_PROFILE',
 'default'),
 +                                    'accounts')
 +        os.environ.setdefault('MC_ACCOUNT_DIR', accounts_dir)
 }}}

 That should probably rather go into the sugar script, not sugar-jhbuild.

 Have you tried building Telepathy (using your patch) on all supported
 distros?

 Please post the improved patch on sugar-devel, that makes it much easier
 for me to track and review it.

-- 
Ticket URL: <http://bugs.sugarlabs.org/ticket/2228#comment:5>
Sugar Labs <http://sugarlabs.org/>
Sugar Labs bug tracking system